lukasroegner / homebridge-philips-hue-sync-box

Homebridge plugin for the Philips Hue Sync Box.
MIT License
57 stars 13 forks source link

TV accesory state #15

Closed adamrzanek closed 4 years ago

adamrzanek commented 4 years ago

The TV Accesory HDMI input tile doesn’t sync with actual state of the device in home app and hue app on the latest update.

lukasroegner commented 4 years ago

The previous implementation had some issues, please take the steps described in #13 to re-enable the accessory.

adamrzanek commented 4 years ago

Thanks, but i didn’t help :( It’s on in hue app and off in apple home

On 27 Jul 2020, at 19:26, Lukas Rögner notifications@github.com wrote:

 The previous implementation had some issues, please take the steps described in #13 to re-enable the accessory.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

lukasroegner commented 4 years ago

Please start Homebridge in debug mode (parameter -D) and check the logs for "Updated state to ...". If those match the the state in the Hue app, then there is a bug in the plugin.

What version of the Sync Box are you running? Mine is firmware 1.4.7, which is the latest firmware according to the Hue Sync app.

adamrzanek commented 4 years ago

Ok, this is the log from homebridge. It’s of in home app and i have the 1.4.7 firmware

On 27 Jul 2020, at 19:42, Lukas Rögner notifications@github.com wrote:

 Please start Homebridge in debug mode (parameter -D) and check the logs for "Updated state to ...". If those match the the state in the Hue app, then there is a bug in the plugin.

What version of the Sync Box are you running? Mine is firmware 1.4.7, which is the latest firmware according to the Hue Sync app.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

lukasroegner commented 4 years ago

The logs are missing in your post, I don‘t think that mail attachments are added to the post on GitHub.

adamrzanek commented 4 years ago

Oh sorry 6A5CCCBD-3695-4FBC-AD31-3B043362CC26

adamrzanek commented 4 years ago

And this is actual home app state 36C8209D-62A9-49DF-87EA-3C68ACB619F0

lukasroegner commented 4 years ago

I see, this is a change that I introduced: the state is exposed as „Off“ if the Sync Box is in power save OR passthrough mode, i.e. no synchronization.

adamrzanek commented 4 years ago

Ok, thanks. So what is correct option to get it synched?

On 27 Jul 2020, at 20:20, Lukas Rögner notifications@github.com wrote:

 I see, this is a change that I introduced: the state is exposed as „Off“ if the Sync Box is in power save OR passthrough mode, i.e. no synchronization.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

lukasroegner commented 4 years ago

The idea is that the ON state shows that the Sync Box is syncing, the OFF state means that the Sync Box is not syncing. You can play around with the defaultOnMode (I recommend the value lastSyncMode, which means that switching to ON in the Home app enables the last on mode, which can be video, music or game) and the defaultOffMode, which can be powersave or passthrough.

powersave is the state where the toggle button on the Hue Sync app is switched off. passthrough is the state that is shown in your screenshot: the Sync Box is "on", but not syncing.

Those modes determine the target state to which the Sync Box is switched when you change the value in HomeKit.

If I would change the implementation to show the ON state in case of passthrough (the state of your screenshots), you would never have the option to start synchronization via the Home app (as it would already show as ON). Thus, it is displayed as OFF if syncing is not active.

lukasroegner commented 4 years ago

@adamrzanek @padman74 If you want me to change the behavior of the ON/OFF button of the TV accessory, I'll do that.

We need to decide:

We can use the following states: passthrough, powersave, video, music, game Moreover, the Sync Box has the property lastSyncMode, which can be video, music, game

padman74 commented 4 years ago

For me the Tv accessory is just to change the input channel and to switch the box on/off (toggle: powersave = off; passthrough = on | State when on = passthrough/Video/Game/Music; off = powersave ). Syncing can be controlled with the bulb. For that the config parameters are fine for now ;)

lukasroegner commented 4 years ago

@padman74 Yes, that makes sense, syncing can be controlled via the lightbulb service. I updated the plugin so that the TV accessory can actually change between powersave and passthrough with the ON/OFF switch.

padman74 commented 4 years ago

Still the on status remains although the sync box switched to sleep mode.

adamrzanek commented 4 years ago

It works for me now the way i wanted. Set tv accessory to false than reset homebridge. And set it to true again.

On 31 Jul 2020, at 08:35, padman74 notifications@github.com wrote:

 Still the on status remains although the sync box switched to sleep mode.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

padman74 commented 4 years ago

The point is when the box is been switched off by other sources (hue sync app, usb cable, cec) the add-on should see the change.

lukasroegner commented 4 years ago

@padman74 Are you sure that you have the latest version of the plugin installed and Homebridge restarted?

padman74 commented 4 years ago

Sorry, my fault. From my side ticket can be closed.