search

lukasvdgaag / SkyWarsReloaded

The most popular Skywars plugin ever built for Spigot and Bukkit!
https://www.gcnt.net/skywars
48 stars 29 forks source link

Registration process occurs after the saving process #23

Closed Budderman18 closed 10 months ago

Budderman18 commented 3 years ago

In order to save a map, you must register it first. However, when you go to register a map, it has to save it first. However, when the game goes to save a map, my guess is it checks to see if a map was registered. If it isn't, it doesn't save. Then after that, the map gets registered. Because of this, saving maps is currently impossible (since maps unregister themselves when being edited, and you can't save a map that's not in edit mode).

The console does not output any errors, so I don't really have anything else to show.

TechnicallyCoded commented 3 years ago

You save, then register. That is the intended order.

Budderman18 commented 3 years ago

If you try and save a map that isnt registered, it'll say "This map needs to be registered first!", and deletes the world. If you then go to register, it will succeed but will kick you out and wont save anything. If you try to edit a map the is registered, it will unregister itself, putting you in an infinite loop of trying to save but the plugin essentially not allowing it.

TechnicallyCoded commented 3 years ago

image That message does not exist in the plugin.

Budderman18 commented 3 years ago

"You have to register the arena to save your changes!" is exactly what it says

Budderman18 commented 3 years ago

Update: The latest update kindve fixed this. Sometimes the maps wont save, but sometimes they do. Again, no errors show up.

TechnicallyCoded commented 3 years ago

I just checked the code, and that does no prevent it from being saved. It is mostly not said correctly. I was supposed to say that you need to register in order for the map to be joinable.