search

lukasz-galka / ngx-gallery

Angular image gallery plugin
https://lukasz-galka.github.io/ngx-gallery-demo/
MIT License
436 stars 172 forks source link

Is this project died? #293

Open kolkov opened 4 years ago

kolkov commented 4 years ago

I recreated this package as Angular CLI standard library project with demo app and simple tests. I can make pull request or we can simple continue developing this project in my github repo. Thanks a lot! https://github.com/kolkov/ngx-gallery

omikolaj commented 4 years ago

Does your repo support angular 8? Are you thinking of creating an NPM package? I would like to use it if you have it working with Angular 8? It is currently broken in one of my projects, so I ll have to think about alternatives

kolkov commented 4 years ago

@omikolaj yes, it is created with Angular 8+ initially. Yes, I created Angular library package at npmjs because this repo is frozen at this moment. All API saved. https://www.npmjs.com/package/@kolkov/ngx-gallery

omikolaj commented 4 years ago

Time savior!! I super appreciate your work. I just shaved off couple weeks worth of work trying to find another gallery package, write my own or patch this one up. Thanks a lot! Did you make any additions? Or just left it as is and got it working with angular 8+?

kolkov commented 4 years ago

@omikolaj Thanks! At this moment I try to adapt this lib to work with upcoming Angular 9. But I found many bugs with Ivy enabled. Now I am waiting for issues fixed by Angular team. https://github.com/angular/angular/issues/34128 In addition I want to add some new functionality to the package, including litebox directive and galleriz.

omikolaj commented 4 years ago

Okay. If you can. Try to keep posted in here too.

kolkov commented 4 years ago

Ok, but the best way, subscribe for changes of my repo.

omikolaj commented 4 years ago

I’ll just do that! Thanks again!

solcre-gr commented 4 years ago

@lukasz-galka it is true?