search

lukaszflorczak / vue-agile

🎠 A carousel component for Vue.js
https://lukaszflorczak.github.io/vue-agile/
MIT License
1.49k stars 167 forks source link

Fixes for touchmove event listener and scrolling #161

Closed lukaszflorczak closed 2 years ago

lukaszflorczak commented 4 years ago

Closes #141

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

alersenkevich commented 4 years ago

Closes #141

so i checked this out, and seems that is good, swipe now works on mobile correctly

it can be used for now

alersenkevich commented 4 years ago

but also you need to know that your component have a many problems yet, so i switched the lib for awesome-swiper from chineese people and i enjoy it, although it doesnt work properly on last version, but i can fixed it for 5 minutes and it's easier than fix your case

Tragio commented 3 years ago

Hi @lukaszflorczak! Thank you for your amazing work. I would love to know if this will ever be merged and if this is still maintained. Thank you very much!

rlam3 commented 3 years ago

@lukas-pierce I'm having a problem with lighthouse with this package and event listener. Lighthouse is complaining about the not setting passive into the eventlistener I believe according to: https://stackoverflow.com/questions/47327119/how-to-listen-to-scroll-events-in-vue-nuxtjs

https://github.com/lukaszflorczak/vue-agile/blob/3b0218cb72f87d0644091b98c505d65770498064/src/Agile.vue#L197-L226

Another reference: https://web.dev/uses-passive-event-listeners/ document.addEventListener('touchstart', onTouchStart, {passive: true});

Screen Shot 2021-05-08 at 7 40 25 AM

Screen Shot 2021-05-08 at 7 40 12 AM

points to 230 - touchstart 232 - touchmove