search

lukaszflorczak / vue-agile

🎠 A carousel component for Vue.js
https://lukaszflorczak.github.io/vue-agile/
MIT License
1.49k stars 167 forks source link

Fix: destroy don't triggered in Vue 2 #224

Closed mdunisch closed 2 years ago

mdunisch commented 2 years ago

Hey @lukaszflorczak you missed the "vue 2" part of my MR (https://github.com/lukaszflorczak/vue-agile/pull/216/files#diff-08eda04003f9354401feadd60a810eec56c70617a1e28cfb8ecf9ff5a7605596R220) or lost it in the merge.

Keep beforeDestroy-method makes it compatible with vue 2 as well as vue 3!

mdunisch commented 2 years ago

ahh i saw the version 2 is a vue 3 only - so forget about my PR ;-)