search

lukaszflorczak / vue-agile

🎠 A carousel component for Vue.js
https://lukaszflorczak.github.io/vue-agile/
MIT License
1.49k stars 167 forks source link

SASS issue #82

Closed SavkaTaras closed 5 years ago

SavkaTaras commented 5 years ago

SASS is not compiled properly. npm thorws the error during dev. Once deleted the sass from node_modules it seems to be working okay.

lukaszflorczak commented 5 years ago

Hi.

  1. Could you show the error?
  2. What version of node.js do you have?
  3. Do you have sass in your project (dev) dependencies? What version?
SavkaTaras commented 5 years ago

Hi!

Node version 8.9.0. Node-sass is installed as a part of vue cli set up. (4.11.0 version)

See attached file with logged error.

Thanks, Taras Savka

From: Ɓukasz Florczak Sent: Wednesday, April 24, 2019 11:21 AM To: lukaszflorczak/vue-agile Cc: Taras Savka; Author Subject: Re: [lukaszflorczak/vue-agile] SASS issue (#82)

Hi.

  1. Could you show the error?
  2. What version of node.js do you have?
  3. Do you have sass in your project (dev) dependencies? What version? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

ERROR Failed to compile with 1 errors 11:24:33

error in ./node_modules/vue-agile/src/Agile.vue?vue&type=style&index=0&lang=sass&

Module build failed (from ./node_modules/sass-loader/lib/loader.js):

// All content of Agile.vue file was here

^ Invalid CSS after " ": expected 1 selector or at-rule, was "{" in C:\WebProjects\VueJS\projectname\node_modules\vue-agile\src\Agile.vue (line 1, column 1)

@ ./node_modules/vue-style-loader??ref--9-oneOf-1-0!./node_modules/css-loader??ref--9-oneOf-1-1!./node_modules/vue-loader/lib/loaders/stylePostLoader.js!./node_modules/postcss-loader/src??ref--9-oneOf-1-2!./node_modules/sass-loader/lib/loader.js??ref--9-oneOf-1-3!./node_modules/cache-loader/dist/cjs.js??ref--0-0!./node_modules/vue-loader/lib??vue-loader-options!./node_modules/vue-agile/src/Agile.vue?vue&type=style&index=0&lang=sass& 4:14-357 14:3-18:5 15:22-365 @ ./node_modules/vue-agile/src/Agile.vue?vue&type=style&index=0&lang=sass& @ ./node_modules/vue-agile/src/Agile.vue @ ./node_modules/vue-agile/src/index.js @ ./src/router.js @ ./src/main.js @ multi (webpack)-dev-server/client?http://10.1.69.90:8080/sockjs-node (webpack)/hot/dev-server.js ./src/main.js

lukaszflorczak commented 5 years ago

Dependencies in the component package.json:

    "sass": "^1.18.0",
    "sass-loader": "^7.1.0",

are also from default project created by vue-cli@3.6.x. I'll check this.

SavkaTaras commented 5 years ago

Thank you, I will check this out.

On Wed, Apr 24, 2019 at 11:39 AM Ɓukasz Florczak notifications@github.com wrote:

Dependencies in the component package.json:

"sass": "^1.18.0",
"sass-loader": "^7.1.0",

are also from default project created by vue-cli 3.6.x. I'll check this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lukaszflorczak/vue-agile/issues/82#issuecomment-486295848, or mute the thread https://github.com/notifications/unsubscribe-auth/AI3HTL7MRC6XKGQGFBWDMJTPSB5KHANCNFSM4HIEF36Q .

guillecro commented 5 years ago

I confirm that i am having the same error here.. sadly I will have to use another component, but i am glad this was reported

Module build failed (from ./node_modules/sass-loader/lib/loader.js):

<template>
^
      Invalid CSS after " ": expected 1 selector or at-rule, was "{"
      in /home/zaqueo/dev/arff-front/node_modules/vue-agile/src/Agile.vue (line 
1, column 1)
lukaszflorczak commented 5 years ago

~Unfortunately, I can't imitate the bug in my environment. Maybe someone with that problem will be able to share with me a repository or though package.json with all dependencies and npm/yarn lock file? It will be very helpful.~

OK... Finally, I got this! I think my mistake was I used sass in the component. I'll change it to CSS. The update will be available soon.

lukaszflorczak commented 5 years ago

Check v1.0.5 update and let me know if it helped.

SavkaTaras commented 5 years ago

Are you using sass or scss, or did you switch to dart-sass?

Sent from Mail for Windows 10

From: Ɓukasz Florczak Sent: Friday, April 26, 2019 3:20 PM To: lukaszflorczak/vue-agile Cc: Taras Savka; Author Subject: Re: [lukaszflorczak/vue-agile] SASS issue (#82)

Unfortunately, I can't imitate the bug in my environment. Maybe someone with that problem will be able to share with me a repository or though package.json with all dependencies and npm/yarn lock file? It will be very helpful. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

lukaszflorczak commented 5 years ago

@SavkaTaras I updated this comment before you replied. Test also v1.0.5 release, please.

SavkaTaras commented 5 years ago

Thank you. I will try in few hours. Not in from of my laptop now.

Thanks

Sent from Mail for Windows 10

From: Ɓukasz Florczak Sent: Friday, April 26, 2019 3:51 PM To: lukaszflorczak/vue-agile Cc: Taras Savka; Author Subject: Re: [lukaszflorczak/vue-agile] SASS issue (#82)

Check v1.0.5 update and let me know if it helped. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

SavkaTaras commented 5 years ago

Fixed in 1.0.5.

Thanks!