lukaszlach / clip

:whale: Docker Client Plugins Manager - build new plugins, publish them on Docker Hub or just try some plugins from the catalog and install them locally
https://lach.dev/clip
MIT License
131 stars 13 forks source link

Better docs for exposing ports to public #3

Closed disconnect3d closed 5 years ago

disconnect3d commented 5 years ago

There should be more information in the readme regarding exposing ports to the public i.e.:

I agree ppl can see that in the code but I'd expect a good project to have such crucial info in the readme.

lukaszlach commented 5 years ago

The first three points are covered in the plugin documentation - https://github.com/lukaszlach/clip/tree/master/clips/expose The last point is something I was also thinking about, dive and runlike are run from the official images (created by the authors of the respective tools), ngrok does not have an official image, I use the one I have been using since. It may be a good idea to create a dedicated image for this plugin.

lukaszlach commented 5 years ago

"expose" clip now uses an image from my namespace, until ngrok creates its own official one.