search

lukazbaum / discordjs-command-handler

A comprehensive TypeScript command handler for Discord.js, featuring slash commands, prefix commands, message commands, events, automatic intents, and more.
MIT License
5 stars 1 forks source link

[BUG] node opencollective is deprecated #7

Closed jbasalone closed 2 months ago

jbasalone commented 2 months ago

Bug Report

Description

../..node_modules/opencollective/dist/commands/donate-help.

OpenCollective has been removed and no longer supported. Is it required anywhere for the package?

To Reproduce

Environment (please complete the following information):

Additional Context

sample error 

ESC[31m[ERROR] Failed to load command at ../..node_modules/opencollective/dist/commands/donate-help.jsESC[0m Error: Cannot find module '../..node_modules/opencollective/dist/commands/donate-help.js'
Require stack:
- /home/ubuntu/new_parkman/dist/handler/util/handleCommands.js
- /home/ubuntu/new_parkman/dist/handler/util/DiscordClient.js
- /home/ubuntu/new_parkman/dist/index.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1143:15)
    at Module._load (node:internal/modules/cjs/loader:984:27)
    at Module.require (node:internal/modules/cjs/loader:1231:19)
    at require (node:internal/modules/helpers:179:18)
    at /home/ubuntu/new_parkman/dist/handler/util/handleCommands.js:25:99
    at async getCommandModules (/home/ubuntu/new_parkman/dist/handler/util/handleCommands.js:25:29)
    at async registerCommands (/home/ubuntu/new_parkman/dist/handler/util/handleCommands.js:16:5)
    at async DiscordClient.registerCommands (/home/ubuntu/new_parkman/dist/handler/util/DiscordClient.js:49:9)
    at async /home/ubuntu/new_parkman/dist/index.js:13:5 {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/ubuntu/new_parkman/dist/handler/util/handleCommands.js',
    '/home/ubuntu/new_parkman/dist/handler/util/DiscordClient.js',
    '/home/ubuntu/new_parkman/dist/index.js'
  ]
}

Possible Solution (optional)

remove opencollective requirements

Thank you for taking the time to report a bug. Your feedback is valuable to us and helps improve the quality of the Discord Bot Handler.

lukazbaum commented 2 months ago

Hello,

The repository does not include a package named opencollective. It appears that the handler is trying to register the "donate-help" command from opencollective.

I was unable to reproduce the bug on my end, but I believe it should be resolved in the latest commit.

Additionally, I am currently working on a newer version of the handler. If you have any feedback, suggestions, or features you would like to see added, please let me know.

jbasalone commented 2 months ago

suggestions: btw I love it so much so I dont have a ton. I will be releasing it in production this week to replace the old pile of yuck I have now. so I might have more.

(re) loadable modules vs the entire program <- one I would love prefix is not case sensitve <- nice to have built in pagination <- nice to have modals are a little confusing on how they are loaded events loading is a little nervous because the main event like "messageCreate" has the main trigger for the program so being able to have a separate event loader for custom events (based on message triggers from other bots for instance) would make it a little safer.

jbasalone commented 2 months ago

forgot to add that the commit resolves it <3

lukazbaum commented 2 months ago

Okay, thank you. I'll try to add everything :) Feel free to open an issue if you have more suggestions.