search

lukbukkit / chartist-plugin-tooltip

Tooltip plugin for Chartist.js
MIT License
16 stars 13 forks source link

Support tooltips on solid donut charts #4

Closed petervtzand closed 4 years ago

petervtzand commented 4 years ago

Right now when using a donut chart and donutSolid=true, tooltips don't work because the tooltip is set on the tooltipSelector ct-slice-donut instead of ct-slice-donut-solid. So I fixed that.

This is already fixed in the 'original' repo, but the changes are not pushed to NPM. Since this repo looks better maintained I created a PR for this here.

petervtzand commented 4 years ago

btw. I don't know exactly how the min.js and min.js.map works. I minified the js file online, but I don't know how to create the min.js.map.

lukbukkit commented 4 years ago

Thanks for your pull request, otherwise I wouldn't noticed the changes in the base repository.

All files in the dist directory are generated by grunt, so we usally don't edit these files. Grunt uses the code from src/scripts/chartist-plugin-tooltip.js to generate the distribution files.

I guess the best way to stay in sync with the main repository (tmmdata/chartist-plugin-tooltip) is to merge the commit from AlexLaforge's pull request #173.

This means that I'll close this pull request, but thanks a lot. The changes will be published to NPM no later than the weekend.

lukbukkit commented 4 years ago

The latest version v0.1.2 of this plugin is now published on NPM.

Thanks a lot!