search

luke-chang / js-spatial-navigation

A javascript-based implementation of Spatial Navigation.
Mozilla Public License 2.0
371 stars 117 forks source link

fix(onKeyUp): keys with modifiers should be ignored #16

Closed themihai closed 7 years ago

themihai commented 7 years ago

Unless we ignore the modifier keys the lib seems to break various shortcuts. For example in Chrome CMD + Arrow Left/Right doesn't work anymore thus the client is unable to manage the browser history using the keyboard. This commit intends to fix just that.

luke-chang commented 7 years ago

Thanks a lot for raising this issue and also your patch. It works well now. Would you mind squashing them into one commit?

themihai commented 7 years ago

Done!

luke-chang commented 7 years ago

Thanks for your patch.