search

luke-jr / eloipool

Fast Python3 Bitcoin pool server
Other
136 stars 69 forks source link

Update for authserviceproxy #4

Closed mike-holcomb closed 9 years ago

mike-holcomb commented 9 years ago

Changed references from jsonrpc to bitcoinrpc and removed references to midstate

luke-jr commented 9 years ago

What's the point? python-bitcoinrpc provides the jsonrpc module that works fine here. I see no reason to unnecessarily break compatibility...

And midstate is still used when available.

mike-holcomb commented 9 years ago

I was just submitting the changes I made to get it to run. I should've added something more elegant for the cases to fall back on old jsonrpc when available.

Also I can't find midstate at the link in the README or with cursory Google searches, so I figured it was dead/deprecated. You're correct that the current lines handle missing misstate well.

Great piece of code - donated 0.15BTC to say thanks