search

lukePeavey / SplitType

Javascript utility that splits text into lines, words, characters for animation
https://lukepeavey.github.io/SplitType/
558 stars 40 forks source link

Fix invalid capitalization #4

Closed bakura10 closed 3 years ago

bakura10 commented 3 years ago

Using pageXoffset and pageYoffset (with the o not capitalized) returned undefined (at least on Chrome) so it constantly scrolls to the top. Can this be merged and a new version being tagged on NPM?

lukePeavey commented 3 years ago

You're absolutely right it should be pageYOffset. Thanks for fixing this! I will go ahead and merge your PR. I will also publish a new version on NPM.

bakura10 commented 3 years ago

Thanks a lot :)

lukePeavey commented 3 years ago

@bakura10

Just wanted to let you know I published a new version on npm that includes your changes. The npm package is called split-type now.

Thanks again for the contribution!

bakura10 commented 3 years ago

Really appreciate it, thanks ;)