search

lukealford / abb-speedtest-cli

A cli tool for running aussie broadband speed test
MIT License
9 stars 6 forks source link

"Quiet mode" has misleading description #12

Closed TJC closed 4 years ago

TJC commented 4 years ago

The --quiet mode is described as: 

.option('-q, --quiet [optional]', 'disables result reporting to ABB')

However the actual effect in the code seems to be mixed -- it also reduces the verbosity of console log output (see #11 )

Could I suggest using two flags, perhaps? Maybe --quiet to reduce the console status output down to just the data, and --no-report to disable the reporting back to ABB?

cc @ChrisRiddell @borhub

ghost commented 4 years ago

I’ll discuss this with @lukealford and see what he thinks I’m happy to split them up like that and put in another pull request.

lukealford commented 4 years ago

@ChrisRiddell feel free to do that, don't forget to update the readme ;)

lukealford commented 4 years ago

new option for this is --hide @TJC