lukealford / abb-speedtest-cli

A cli tool for running aussie broadband speed test
MIT License
9 stars 6 forks source link

Add Docker build #7

Closed TJC closed 4 years ago

TJC commented 4 years ago

This PR adds support for building the code into a Docker container, and then run it from within that.

I note that in the process, I had to kind of hack index.js in two ways, which you might want to fix before you merge it into your main branch.

There are probably better ways of achieving those - I suggested using an ENV var for the path, which I imagine is easy for you to fix as you're familiar with Nodejs. See comment in the code.

lukealford commented 4 years ago

This will need more adjustments before it gets merged, hard setting the puppeteer env will break all other systems period. I'll look at this in the near future.

TJC commented 4 years ago

Hi Luke -- I've made some improvements to the script now.