lukeapage / node-markdown-spellcheck

spellchecks markdown files
145 stars 58 forks source link

Update dependencies, reformat code and change target node from 4 to 8+ #135

Closed armano2 closed 3 years ago

armano2 commented 4 years ago

small note: (node 8)

this is not actual benchmark but validation is way faster

@robatwilliams @lukeapage

armano2 commented 4 years ago

Update: Tests now are executed without exceptions found on master and some of them are fixed to actually do stuff instead of being broken due to mix between sync/async calls)

https://travis-ci.org/lukeapage/node-markdown-spellcheck/jobs/593726326#L283

read more

``` cli interactive ✓ should work with no mistakes (105ms) ✓ should work with a single ignore (node:5062) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'action' of undefined at /home/travis/build/lukeapage/node-markdown-spellcheck/es5/cli-interactive.js:114:20 at at process._tickDomainCallback (internal/process/next_tick.js:229:7) (node:5062) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1) (node:5062) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code. (node:5062) UnhandledPromiseRejectionWarning: AssertionError: expected false to equal true at /home/travis/build/lukeapage/node-markdown-spellcheck/test/cli-interactive.js:83:43 at at process._tickDomainCallback (internal/process/next_tick.js:229:7) (node:5062) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2) ✓ correct word with 2 words (node:5062) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'action' of undefined at /home/travis/build/lukeapage/node-markdown-spellcheck/es5/cli-interactive.js:114:20 at at process._tickDomainCallback (internal/process/next_tick.js:229:7) (node:5062) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 3) (node:5062) UnhandledPromiseRejectionWarning: AssertionError: expected false to equal true at /home/travis/build/lukeapage/node-markdown-spellcheck/test/cli-interactive.js:101:53 at at process._tickDomainCallback (internal/process/next_tick.js:229:7) (node:5062) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 4) ✓ correct word with incorrect word (node:5062) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'action' of undefined at /home/travis/build/lukeapage/node-markdown-spellcheck/es5/cli-interactive.js:114:20 at at process._tickDomainCallback (internal/process/next_tick.js:229:7) (node:5062) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 5) (node:5062) UnhandledPromiseRejectionWarning: AssertionError: expected false to equal true at /home/travis/build/lukeapage/node-markdown-spellcheck/test/cli-interactive.js:130:52 at at process._tickDomainCallback (internal/process/next_tick.js:229:7) (node:5062) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 6) ✓ correct word with filtered word (node:5062) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'action' of undefined at /home/travis/build/lukeapage/node-markdown-spellcheck/es5/cli-interactive.js:114:20 at at process._tickDomainCallback (internal/process/next_tick.js:229:7) (node:5062) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 7) (node:5062) UnhandledPromiseRejectionWarning: AssertionError: expected false to equal true at /home/travis/build/lukeapage/node-markdown-spellcheck/test/cli-interactive.js:156:48 at at process._tickDomainCallback (internal/process/next_tick.js:229:7) (node:5062) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 8) ```

JaKXz commented 3 years ago

This is awesome! @lukeapage sorry to ping on an old PR but I'd say this is a worthy PR for v2.0?

armano2 commented 3 years ago

due to lack of interest in this PR, i'm closing this, i moved away from this library to cspell