lukearran / TvTimeToTrakt

A Python script to import TV Time data into Trakt.TV
MIT License
147 stars 17 forks source link

Movie support and refactoring #26

Closed marnym closed 1 year ago

marnym commented 1 year ago

Hello,

Thanks a lot for the script. This saved a lot of time at least for me and hopefully for other people too.

I initially continued on where @SinTan1729 worked on movies and seems like you already merged it in #17. IMO the changes were not quite ready yet, but of course you decide what you merge.

I tried to write the code as DRY as possible by using two abstract classes: Searcher, which searches first TinyDB for TV Shows and Movies then from Trakt. And Processor which processes the TV Time data. Both abstract classes contain the common logic and then the subclasses override any specific behavior.

I also made some other improvements like:

I would also be happy to implement some of the open issues.

lukearran commented 1 year ago

Thanks for your contribution. This is fantastic work, and was very much needed! :)