Thanks a lot for the script. This saved a lot of time at least for me and hopefully for other people too.
I initially continued on where @SinTan1729 worked on movies and seems like you already merged it in #17. IMO the changes were not quite ready yet, but of course you decide what you merge.
I tried to write the code as DRY as possible by using two abstract classes: Searcher, which searches first TinyDB for TV Shows and Movies then from Trakt. And Processor which processes the TV Time data. Both abstract classes contain the common logic and then the subclasses override any specific behavior.
I also made some other improvements like:
Added typing
Tried to simplify logic where possible
Moved some logic to own files
Shows progress as a percentage
For some movies the release date is available, this is read to avoid asking user for input
Handles any Exception when processing files (I got a: requests.exceptions.ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response')) when processing)
I would also be happy to implement some of the open issues.
Hello,
Thanks a lot for the script. This saved a lot of time at least for me and hopefully for other people too.
I initially continued on where @SinTan1729 worked on movies and seems like you already merged it in #17. IMO the changes were not quite ready yet, but of course you decide what you merge.
I tried to write the code as DRY as possible by using two abstract classes:
Searcher
, which searches firstTinyDB
for TV Shows and Movies then from Trakt. AndProcessor
which processes the TV Time data. Both abstract classes contain the common logic and then the subclasses override any specific behavior.I also made some other improvements like:
Exception
when processing files (I got a: requests.exceptions.ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response')) when processing)I would also be happy to implement some of the open issues.