Set importsNotUsedAsValues to error

[quarhodron]

After I generated routes.ts I get the error:

I think it's safe to set "importsNotUsedAsValues": "error" in tsoa tsconfig since it wouldn't affect current user configs while it will help those who just like me have it set it to error in my own tsconfig.

Sorting

• I'm submitting a ...

  • [ ] bug report
  • [x] feature request
  • [ ] support request

• I confirm that I

  • [x] used the search to make sure that a similar issue hasn't already been submit

Expected Behavior

routes.ts

import type * as KoaRouter from '@koa/router';

Current Behavior

routes.ts

import * as KoaRouter from '@koa/router';

Possible Solution

changing this line https://github.com/lukeautry/tsoa/blob/7c05b4d3f67c313752d38e0efc6826f64b4f27fe/packages/cli/src/routeGeneration/templates/koa.hbs#L22 and setting "importsNotUsedAsValues": "error" in tsconfig.json

Steps to Reproduce

set "importsNotUsedAsValues": "error" in tsconfig.json

Breaking change?

no

[panwauu]

Having the same problem with import * as express from 'express'; instead of import type * as express from 'express';. Would be very happy for this easy update

[panwauu]

Another fix would be to add // @ts-ignore before the import

[WoH]

Having the same problem with import * as express from 'express'; instead of import type * as express from 'express';. Would be very happy for this easy update

Would you like to open a PR?

[panwauu]

I have not contributed to tsoa up to now so I would need some pointers on where to adapt this behvaior. (I could not find it within some seconds).

[WoH]

https://github.com/lukeautry/tsoa/tree/master/packages/cli/src/routeGeneration/templates

[panwauu]

Dayum. How could I miss this 🙄 PR is set