Closed lalchan closed 11 months ago
Need help to expand this feature into koa and hapi, also need help to write test cases, as i was not able to find where the test cases for the RegisterRoutes
functions were.
koa seems to be very similar to express in this instance so went forward and implemented the injection in a similar method, still need help with hapi.
koa seems to be very similar to express in this instance so went forward and implemented the injection in a similar method, still need help with hapi.
Hapi has this included and does not use multer iirc. So feel free to pretend that doesn't exist
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days
@WoH I think this feature is completed but accidentally close by bot. Maybe you can reopen and review it.
have change the import to a type only import as asked here
added the commits in my fork, would like to have them also be included in this PR, Cannot figure out how to. Creating a new PR as expected, created a new PR (expected it would find pre-existing PR and add the commits into it) any help would be appreciated to add the new commits
All Submissions:
If this is a new feature submission:
[x] Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project? - > see #1483
Added multer instance injection into
RegisterRoutes
.Created a new Type RegisterRoutesOptions which currently only has
{multer: multer.Multer}
as it's property this could be expanded as required in future.