Closed hpx7 closed 7 months ago
@WoH does this look ok to merge?
Can you add a test please? Add it to the test model and make sure the spec is fine.
Can you add a test please? Add it to the test model and make sure the spec is fine.
I have added a test, please take a look and let me know if you'd like me to add any more.
The macos-latest build failure seems to be a flake.
LGTM!
You could check for additonalProperties which should, regardless of the runtime validation strictness should be false here. But this is a clear improvement, so I'm happy to merge it as is. Thanks for opening a PR!
All Submissions:
Closing issues
Closes #1535
Potential Problems With The Approach
Test plan