Handle Record<string, never> type

lukeautry / tsoa

Build OpenAPI-compliant REST APIs using TypeScript and Node

MIT License

3.42k stars 489 forks source link

Handle Record<string, never> type #1537

Closed hpx7 closed 7 months ago

hpx7 commented 7 months ago

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] Have you written unit tests?
[ ] Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
[x] This PR is associated with an existing issue?

Closing issues

Closes #1535

Potential Problems With The Approach

Test plan

hpx7 commented 7 months ago

@WoH does this look ok to merge?

WoH commented 7 months ago

Can you add a test please? Add it to the test model and make sure the spec is fine.

hpx7 commented 7 months ago

Can you add a test please? Add it to the test model and make sure the spec is fine.

I have added a test, please take a look and let me know if you'd like me to add any more.

The macos-latest build failure seems to be a flake.

WoH commented 7 months ago

LGTM!

WoH commented 7 months ago

You could check for additonalProperties which should, regardless of the runtime validation strictness should be false here. But this is a clear improvement, so I'm happy to merge it as is. Thanks for opening a PR!