feat: added ability to pass multerInstance into RegisterRoutes

lalchan commented 7 months ago

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] Have you written unit tests?
[ ] Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
[x] This PR is associated with an existing issue?

If this is a new feature submission:

[x] Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project? - > see #1483
Added multer instance injection into RegisterRoutes.
Created a new Type RegisterRoutesOptions which currently only has {multer: multer.Multer} as it's property this could be expanded as required in future.

Put closes #XXXX (where XXXX is the issue number) in your comment to auto-close the issue that your PR fixes.

If this is a new feature submission:

[ ] Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project?

Potential Problems With The Approach

Test plan

lalchan commented 7 months ago

I apologize, I wanted to add new commits to the old PR, and thought creating a new PR would add new commits to the old PR, Closing this PR as creating a new PR is not the intention

lalchan commented 7 months ago

Reopening this PR as I cannot figure out how to add my new commits to the old PR, sorry for being so incompetent

jackey8616 commented 7 months ago

@WoH Are you planning to deprecate multerOptions in this PR?

WoH commented 7 months ago

@jackey8616 yeah eventually, but non-breaking would be appreciated by everyone else I think

jackey8616 commented 7 months ago

@jackey8616 yeah eventually, but non-breaking would be appreciated by everyone else I think

IMO, this PR can focus on - how to support multer instance then after this, I may come out with a solution that deprecates multerOptions without breaking anything also maybe migrate this part of code into TemplateService which #1545 introduced.

github-actions[bot] commented 5 months ago

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

lukeautry / tsoa