Closed lalchan closed 5 months ago
I apologize, I wanted to add new commits to the old PR, and thought creating a new PR would add new commits to the old PR, Closing this PR as creating a new PR is not the intention
Reopening this PR as I cannot figure out how to add my new commits to the old PR, sorry for being so incompetent
@WoH Are you planning to deprecate multerOptions in this PR?
@jackey8616 yeah eventually, but non-breaking would be appreciated by everyone else I think
@jackey8616 yeah eventually, but non-breaking would be appreciated by everyone else I think
IMO, this PR can focus on - how to support multer instance
then after this, I may come out with a solution that deprecates multerOptions without breaking anything also maybe migrate this part of code into TemplateService
which #1545 introduced.
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days
All Submissions:
If this is a new feature submission:
[x] Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project? - > see #1483
Added multer instance injection into
RegisterRoutes
.Created a new Type RegisterRoutesOptions which currently only has
{multer: multer.Multer}
as it's property this could be expanded as required in future.Put
closes #XXXX
(where XXXX is the issue number) in your comment to auto-close the issue that your PR fixes.If this is a new feature submission:
Potential Problems With The Approach
Test plan