lukeautry / tsoa

Build OpenAPI-compliant REST APIs using TypeScript and Node
MIT License
3.42k stars 489 forks source link

Nullable regression #1542

Closed hpx7 closed 5 months ago

hpx7 commented 7 months ago

All Submissions:

Closing issues

Put closes #XXXX (where XXXX is the issue number) in your comment to auto-close the issue that your PR fixes.

If this is a new feature submission:

Potential Problems With The Approach

Test plan

hpx7 commented 7 months ago

@WoH before I go further with this, could you quickly take a look and confirm whether the test I added is indeed the desired behavior? The test is currently failing (but it used to work in 5.1.1), and I'd like to try and contribute a fix once I get your confirmation

WoH commented 7 months ago

Yeah. Nullable and x-nullable, but the prop should be required. That's correct

WoH commented 7 months ago

Thanks for taking a look into that

hpx7 commented 6 months ago

@WoH I was able to track down that https://github.com/lukeautry/tsoa/pull/1498 was the change which broke this (the test passes on the commit prior), but I haven't been able to figure out the right way to fix it yet.

github-actions[bot] commented 5 months ago

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days