lukeautry / tsoa

Build OpenAPI-compliant REST APIs using TypeScript and Node
MIT License
3.33k stars 481 forks source link

put type field for nullable #1551

Closed gwprice115 closed 3 months ago

gwprice115 commented 5 months ago

All Submissions:

Closing issues closes https://github.com/lukeautry/tsoa/issues/1550 Put closes #XXXX (where XXXX is the issue number) in your comment to auto-close the issue that your PR fixes.

If this is a new feature submission:

Potential Problems With The Approach

Test plan

gwprice115 commented 5 months ago

would love some confirmation that this will be accepted before i write the test

github-actions[bot] commented 4 months ago

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

gwprice115 commented 4 months ago

i think this is correct but i've hacked around it locally so won't push for it

WoH commented 4 months ago

I think the result is not correct here, esp/ since we should only put a type on the target of the ref and only it it's nullable, right?

gwprice115 commented 4 months ago

I think you're right it's only needed if it's nullable, but putting it on the target of the ref won't solve the issues i linked in the Issue

github-actions[bot] commented 3 months ago

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days