feat: support using custom multer instance in RegisterRoutes

[midoelhawy]

All Submissions:

• [x] Have you followed the guidelines in our Contributing document?
• [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• [x] Have you written unit tests?
• [x] Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
• [x] This PR is associated with an existing issue?

Closing issues

closes #1483

If this is a new feature submission:

• [ ] Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project?

Potential Problems With The Approach

Test plan

[WoH]

LGTM, but can you add a test in one of the setups maybe?

[midoelhawy]

Hi @WoH,

Makes sense. I've now added the automatic tests to avoid bad configuration errors:

cross-env NODE_ENV=tsoa_test mocha "./integration/express-server-custom-multer.spec.ts"

  Express Server With custom multer
    file upload With custom multer instance
      ✔ can post a file (71ms)
      ✔ can post a file without name
      ✔ cannot post a file with wrong attribute name
      ✔ can post multiple files with other form fields
      ✔ can post single file to multi file field
      ✔ can post multiple files with different field
      ✔ can post multiple files with different array fields
      ✔ can post mixed form data content with file and not providing optional file
      ✔ can post mixed form data content with file and provides optional file

  9 passing (239ms)

Thanks!

[midoelhawy]

Hi @WoH,

There were some ESLint errors outside my edited files, but they were resolved by merging master into my branch. Everything works now.

Can you run the tests again, please?

[midoelhawy]

Hi @WoH,

These errors are related to @typescript-eslint rules. They appeared only after cleaning the yarn.lock, so I think they're related to some new @typescript-eslint patch.

/home/work/tsoa/tsoa/packages/cli/src/metadataGeneration/transformer/referenceTransformer.ts
17:40 error This assertion is unnecessary since it does not change the type of the expression @typescript-eslint/no-unnecessary-type-assertion
21:35 error This assertion is unnecessary since it does not change the type of the expression @typescript-eslint/no-unnecessary-type-assertion

/home/work/tsoa/tsoa/packages/cli/src/metadataGeneration/typeResolver.ts
144:43 error This assertion is unnecessary since it does not change the type of the expression @typescript-eslint/no-unnecessary-type-assertion

/home/work/tsoa/tsoa/packages/cli/src/swagger/specGenerator2.ts
441:54 error This assertion is unnecessary since it does not change the type of the expression @typescript-eslint/no-unnecessary-type-assertion

/home/work/tsoa/tsoa/packages/cli/src/swagger/specGenerator3.ts
105:28 error This assertion is unnecessary since it does not change the type of the expression @typescript-eslint/no-unnecessary-type-assertion

I fixed them by ignoring the errors in some cases and by fixing the types when possible.

Can you run the Build action again, please?

[WoH]

LGTM, thanks for your contribution, and, tbh, your patience