[BUG] The Forge-1.19.2-1.2.0 version of the mod is somehow not compatible with OptiFine_1.19.2_HD_U_I1

antauriprime commented 1 year ago

What went wrong?

Launching the game with the following combination of mods: "excavated_variants-forge-1.19.2-1.0.2.jar, dynamic_asset_generator-forge-1.19.2-1.2.0.jar and OptiFine_1.19.2_HD_U_I1.jar" results in an infinite loading screen.

Platform

Forge

Version

43.2.8

Logs and Screenshots

No response

lukebemish commented 1 year ago

First of all, there's nothing I can do without logs.

Second of all, this is a known issue and there's nothing I can do period because of the nature of Optifine. Optifine makes some highly invasive changes to vanilla code that break expectations of vanilla code that mods might depend on. One of these changes consistently breaks DynAssetGen to the point of crashing. As optifine is closed source, there's nothing I can do on my end to find out what that broken expectation is, and even if I could there's likely nothing I could do to fix it. Any fix would have to happen on Optifine's end.

If you provide a log, I can certainly take a look and make some guesses, but it's almost certain that there's nothing I can do from my end, as Optifine is still using approaches that have been obsolete for ages and are known to consistently cause incompatibilities with other mods.

antauriprime commented 1 year ago

Ah, I see. Such a bummer. Sorry, I didn't known this was a known issue, guess I didn't look hard enough. I can't provide the crashlog, because there is no crash. The game just gets stuck at the loading screen, no logs are generated in the process. The best I could do was to provide a clear way of reproducing the bug (running the game with nothing but those 3 .jar files). Is there even a point in reporting this issue to the OptiFine github, you recon? Might as well, though I doubt we'll see any kind of result for a very long time, if ever. And certainly not for 1.19.2.

lukebemish commented 1 year ago

I think you misunderstood me. I don't want the crash log. I want the normal log - probably the debug.log or latest.log file on forge. You should generally always provide that with any bug report. You could try reporting this to Optifine, though I'm unsure whether they'd do anything. But yeah - if I could see the log I might be able to tell what the issue is at least, though it's doubtful I can fix it on my end

antauriprime commented 1 year ago

Oh, yeah, I did misunderstood you. There are the logs:

latest.log 2023-03-31-1.log 2023-03-31-2.log 2023-03-31-3.log 2023-03-31-4.log 2023-03-31-5.log

lukebemish commented 1 year ago

This:

[08:01:03] [Worker-Main-3/WARN]: [OptiFine] Unknown resource pack type: io.github.lukebemish.dynamic_asset_generator.impl.client.DynAssetGenClientResourcePack@d564e84
[08:01:03] [Worker-Main-3/WARN]: [OptiFine] Unknown resource pack type: io.github.lukebemish.dynamic_asset_generator.impl.client.DynAssetGenClientResourcePack@d564e84
[08:01:03] [Worker-Main-3/WARN]: [OptiFine] Unknown resource pack type: io.github.lukebemish.dynamic_asset_generator.impl.client.DynAssetGenClientResourcePack@d564e84
[08:01:03] [Worker-Main-3/WARN]: [OptiFine] Unknown resource pack type: io.github.lukebemish.dynamic_asset_generator.impl.client.DynAssetGenClientResourcePack@d564e84
[08:01:03] [Worker-Main-3/WARN]: [OptiFine] Unknown resource pack file: defaultresources_global
[08:01:03] [Worker-Main-3/WARN]: [OptiFine] Unknown resource pack file: defaultresources_global
[08:01:03] [Worker-Main-3/WARN]: [OptiFine] Unknown resource pack file: defaultresources_global
[08:01:03] [Worker-Main-3/WARN]: [OptiFine] Unknown resource pack file: defaultresources_global
[08:01:03] [Worker-Main-3/WARN]: [OptiFine] Unknown resource pack file: mod_resources
[08:01:03] [Worker-Main-3/WARN]: [OptiFine] Unknown resource pack file: mod_resources
[08:01:03] [Worker-Main-3/WARN]: [OptiFine] Unknown resource pack file: mod_resources
[08:01:03] [Worker-Main-3/WARN]: [OptiFine] Unknown resource pack file: mod_resources

Followed by the many repetitions of this:

[08:01:40] [Worker-Main-3/INFO]: Attempting to provide backup block model for minecraft:block/cube_all
[08:01:40] [Worker-Main-3/INFO]: Could not get backup block model for minecraft:block/cube_all; wildly guessing at texture location.

Makes me thing that Optifine is:

doing some sort of transformation to all resource packs, and failing to do so on resource packs of types it does not recognize (namely, modded ones)
in doing so, probably replacing parts of the vanilla resource loading system outright, so that when DynAssetGen goes to load assets ahead-of-time to construct its own, the assets are just missing

...which probably leads to stuff hanging eventually. Yeah. There's... nothing I can do on my end, without knowing what optifine is doing, and even then I'm not super hopeful. This may still be an issue in 1.19.3/4 - I'm not sure. Probably worth reporting to Optifine anyways, but yeah, whatever's up here, it's not fixable on my end without more knowledge of what Optifine is doing.

antauriprime commented 1 year ago

Alright, I will report this to Optifine. Thanks for your time and effort!

lukebemishprojects / ExcavatedVariants