lukebemishprojects / ExcavatedVariants

Other
10 stars 13 forks source link

Added support for several mods #207

Open vizthex123 opened 1 month ago

vizthex123 commented 1 month ago
vizthex123 commented 1 month ago

I'm hoping the mod dev can figure out why Xychorium variants don't have textures (mentioned it #205). I think it uses a custom shader or something that Dynamic Asset Generator isn't properly detecting.

lukebemish commented 1 month ago

I'll look into the missing textures; I suspect you're write, they probably have some sort of custom model thingy I can't detect. I'll try to review the rest of this PR when I have a chance, though 1.20.1 is fairly low priority right now so it may be a bit.

vizthex123 commented 1 month ago

Alright, that sounds good.

Just wanted to toss in what I'd done to save you some time (I figured it probably wasn't too hard to release an update for 1.20.1 if code wasn't changed) and support a couple major-ish mods that were missing it.

lukebemish commented 1 month ago

Sorry I've been so delayed in looking at this! I should have more free time soon so I'll plan on getting it looked over and merged soon-ish.

vizthex123 commented 1 month ago

noice, thanks.

If you're able to check why it's making Slate variations of vanilla ores when Deeper Caves is installed it'd be nice. The mod adds them already, and I tried to blacklist the default ores but it's not working for me - finally fixed that in https://github.com/lukebemishprojects/ExcavatedVariants/pull/207/commits/690d432dbf4475ecc886febc45adec6bc2189007

If you could check on Xychorium ores not having textures it'd be great. I can open another PR to add them, or add them to this one before it gets merged.