search

lukecavabarrett / pna

Implementation of Principal Neighbourhood Aggregation for Graph Neural Networks in PyTorch, DGL and PyTorch Geometric
https://arxiv.org/abs/2004.05718
MIT License
338 stars 55 forks source link

Bug in argparse #7

Closed zhanqiuzhang closed 3 years ago

zhanqiuzhang commented 3 years ago

It seems that args.divide_input_first and args.divide_input_first will always be True, even if we set --divide_input_first=False in the command line. A similar question can be found here.

gcorso commented 3 years ago

Thanks for noticing, it should be fixed now!

zhanqiuzhang commented 3 years ago

Hi, @gcorso. Thanks for your reply.

Do we need to modify the running script as well? If we can use the previous script to reproduce the results, then both args.divide_input_first and args.divide_input_first should be True. However, using the current script will set them to be False sometimes. The results may be different from previous ones.

gcorso commented 3 years ago

Yes, I believe so. I'll also check that the results & parameters correspond as soon as I have some spare time. Thanks