search

lukechilds / docker-electrumx

Run an Electrum server with one command
MIT License
111 stars 125 forks source link

Update Dockerfile #53

Closed maltokyo closed 4 years ago

maltokyo commented 4 years ago

Add REPORT_SERVICES so ElextrumX can advertise a proper URL ref: https://electrumx.readthedocs.io/en/latest/environment.html#envvar-REPORT_SERVICES

lukechilds commented 4 years ago

ENV REPORT_SERVICES=ssl://${SSL_HOST}:50002 shouldn't be in the Dockerfile by default. If users don't set SSL_HOST or don't use SSL it'll be incorrect.

Instead it should just be set by users that want it enabled at runtime, e.g:

docker run \
  -v /home/username/electrumx:/data \
  -e DAEMON_URL=http://user:pass@host:port \
  -e COIN=BitcoinSegwit \
  -e REPORT_SERVICES=ssl://bitcoin.lukechilds.co:50002 \
  -p 50002:50002 \
  lukechilds/electrumx
maltokyo commented 4 years ago

Ok. Thanks a lot. Indeed. I'm having an issue that I can access the server from electrum wallet perfectly within my network. But not from internet despite port 50002 being open and routing the the right server. I thought maybe it's because if this?

On Mon, 24 Feb 2020, 09:58 Luke Childs, notifications@github.com wrote:

ENV REPORT_SERVICES=ssl://${SSL_HOST}:50002 shouldn't be in the Dockerfile by default. If users don't set SSL_HOST or don't use SSL it'll be incorrect.

Instead it should just be set by users that want it enabled at runtime, e.g:

docker run \ -v /home/username/electrumx:/data \ -e DAEMON_URL=http://user:pass@host:port \ -e COIN=BitcoinSegwit \ -e REPORT_SERVICES=ssl://bitcoin.lukechilds.co:50002,ssl://lukebtc46ko5kgsp.onion:50002 \ -p 50002:50002 \ lukechilds/electrumx

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lukechilds/docker-electrumx/pull/53?email_source=notifications&email_token=AAKS7W56IQ7UK5W2ONWSC3DREOD2HA5CNFSM4KZ3BPEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMXBGQI#issuecomment-590222145, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKS7WY2Q5WEZ3HPDGZNQMLREOD2HANCNFSM4KZ3BPEA .