search

lukechilds / hyperdex-bugtracker

0 stars 1 forks source link

Supernet/KMD orderbooks not populating after two hours #17

Closed 11allbits closed 6 years ago

11allbits commented 6 years ago

HyperDEX 0.0.0-testbuild.7 Electron 2.0.0 linux 4.13.0-39-generic Locale: en-US

lukechilds commented 6 years ago

This would be an issue with marketmaker, we show the order book as soon as it's available.

@artemii235 have you noticed reduce order book performance with the latest builds?

artemii235 commented 6 years ago

@lukechilds Hi, I didn't notice any difference and didn't make any changes to it. Maybe it worth to ask @jl777 about it.

jl777 commented 6 years ago

orderbook is generated locally from whatever price data is available. if the orderbook is not appearing, it would be due to bob nodes not being online, not having prices, or issues with the LP nodes

lukechilds commented 6 years ago

Order book does appear (at least for me) but it has been noticeably slower recently. Most likely just a network issue then, rather than a bug.

lukechilds commented 6 years ago

@jl777 @artemii235 There is definitely a performance issue that's been introduced in marketmaker.

From https://github.com/artemii235/SuperNET/releases

v1.0.156 and v1.0.151 block marketmaker for around 12 seconds every time we call portfolio. I've experimented and it seems to be around 1.5 seconds per currency enabled. With only 2 currencies enabled it's around 3 seconds, with 8 currencies enabled it's around 12 seconds. Sometimes can go up to 1.5mins.

Reverting to v1.0.145 resolves the problem and portfolio calls are returned in about 2-3ms.

That's a performance regression of about 6000x.

To clarify, we're using electrum mode for all coins.

jl777 commented 6 years ago

pushed fix

lukechilds commented 6 years ago

@jl777 Thanks!

@artemii235 are you able to do a new build?

artemii235 commented 6 years ago

@lukechilds Sure, should be ready in 30 minutes.

lukechilds commented 6 years ago

@artemii235 Thanks, are these builds automated btw?

If so, would it be possible to setup automated nightly builds?

artemii235 commented 6 years ago

@lukechilds build are automated, but builds are triggered by push to my repo, it shouldn't take much time to setup same for jl777/SuperNET, need to think a bit about nightly builds. I expect nightly shouldn't be published to Github releases so we need a place for them.

lukechilds commented 6 years ago

Yeah, you could create a marketmaker-nightly repo and just push nightly builds there. That way you don't pollute the stable builds.

Saying that, I don't think there is much active development on marketmaker in jl777/SuperNET due to v2 so maybe it's not worth the effort.

lukechilds commented 6 years ago

I just feel bad pinging you every time we need a new feature/bugfix 😆

artemii235 commented 6 years ago

@lukechilds Here is new release: https://github.com/artemii235/SuperNET/releases/tag/v1.0.160. "Ping" doesn't happen too often, so it's ok now :)

lukechilds commented 6 years ago

@artemii235 Thanks!

jl777 commented 6 years ago

I also just fixed a bug regarding low utxo count alice requests. for some reason it seems possible for both of the utxo pairs to be the same utxo, which of course wont work.

latest version has guards against that and this would avoid the "tx inputs already spent" error -26

lukechilds commented 6 years ago

@artemii235 ☝️ 🙏

artemii235 commented 6 years ago

@lukechilds Published: https://github.com/artemii235/SuperNET/releases/tag/v1.0.164

sindresorhus commented 6 years ago

Closing as we're on the latest marketmaker now.