search

lukechilds / zsh-nvm

Zsh plugin for installing, updating and loading nvm
MIT License
2.22k stars 112 forks source link

Add support for NVM_SILENT environment variable #91 #102

Closed brianmgray closed 5 months ago

brianmgray commented 6 months ago

I ran into the same problem discussed in this PR: https://github.com/lukechilds/zsh-nvm/pull/91

Since the PR was nearly complete, I just addressed the comments and submitted it here.

I have tested it and indeed I no longer get the warning (and continue to switch with no output):

BEFORE Screenshot 2024-03-22 at 4 14 45 PM

AFTER Screenshot 2024-03-22 at 4 24 06 PM

brianmgray commented 6 months ago

@gentslava are you able to review?

gentslava commented 5 months ago

@brianmgray I'm not able to review. Don't have such rights for this repo. You can contribute to my fork and use it instead. It seems this repository is no longer maintained.

brianmgray commented 5 months ago

I saw you merged my PR - I switched over to your fork, and it's working great. Thanks!