search

lukechilds / zsh-nvm

Zsh plugin for installing, updating and loading nvm
MIT License
2.24k stars 113 forks source link

Antigen doesn't fully initialize #19

Closed john-kurkowski closed 7 years ago

john-kurkowski commented 7 years ago

I ran antigen update recently. My themes stopped working. I bisected all my Antigen plugins. Everything works if I exclude zsh-nvm.

I did a git bisect on zsh-nvm, performing antigen reset in between checkouts. Looks like this started with 8bdba4f.

lukechilds commented 7 years ago

Sorry about that! Thanks for doing some digging.

So if you remove return true everything works ok?

Can you tell me your OS/zsh version and what zsh-nvm options (if any) you have enabled?

lukechilds commented 7 years ago

Would you mind trying the fix in https://github.com/lukechilds/zsh-nvm/pull/20 and seeing if it resolves your issue?

lukechilds commented 7 years ago

@john-kurkowski actually, don't worry about that PR, it was a bug that needed fixing regardless of whether it was causing your problem or not so I've merged it into master.

Can you antigen update again and let me know if it's working?

john-kurkowski commented 7 years ago

No dice.

If I remove that line, return 0, it works again.

john-kurkowski commented 7 years ago

Versions/options:

macOS 10.12.1 antigen 1.3.2 zsh 5.3.1

export NVM_DIR=~/.nvm
export NVM_NO_USE=true
lukechilds commented 7 years ago

Hmmn, ok bare with me

lukechilds commented 7 years ago

Ok, appears to be an issue in a recent version of antigen. I just updated my antigen installation and I'm getting the same problem.

I think a plugin should be able to return so I'd consider this a bug in antigen not zsh-nvm. However I'll add a workaround for now so this doesn't affect any other antigen users and raise an issue with them.

lukechilds commented 7 years ago

@john-kurkowski It's working for me now, could you test again?

You may need to delete the zsh-nvm folder so antigen pulls down a fresh copy.

john-kurkowski commented 7 years ago

Works now! Thank you!

lukechilds commented 7 years ago

Thanks for your help on this @john-kurkowski

Issue for antigen is here if you're interested: https://github.com/zsh-users/antigen/issues/386