lukechilds / zsh-nvm

Zsh plugin for installing, updating and loading nvm
MIT License
2.22k stars 112 forks source link

Add NVM_LAZY_LOAD_EXTRA_COMMANDS option #67

Closed joerideg closed 4 years ago

joerideg commented 4 years ago

Here we go, I gave it a shot. It includes tests and documentation in README.md Please review.

joerideg commented 4 years ago

Closes #66

joerideg commented 4 years ago

Are you able to take another look at the test? It should probably be failing since the arrays aren't currently being merged properly. Actually the tests worked before, I tried before pushing the MR.

I've added the changes and amended the commit.

lukechilds commented 4 years ago

@joerideg sorry, haven't had a chance to look at this, got some covid related craziness going on at my end. I haven't forgotten about it, I'll get round to it as soon as I'm able.

joerideg commented 4 years ago

@lukechilds I've updated the MR as requested.

lukechilds commented 4 years ago

Perfect, thanks @joerideg!