lukedirtwalker / cutespotify

A QT5 Spotify client, based on MeeSpot with support for Ubuntu Touch and SailfishOS.
30 stars 9 forks source link

Broken search? #18

Open lukedirtwalker opened 9 years ago

lukedirtwalker commented 9 years ago

http://talk.maemo.org/showpost.php?p=1461748&postcount=297

hetas commented 7 years ago

It seems to me that search breaks when you enter a space in the search field. Search keeps giving results as long as you just type everything together without spaces.

edit: oh, sorry, didn't realise this was an old bug. Search broke for me recently and I was thinking of that.

joonne commented 6 years ago

Hi, search text seems to be trimmed hence the need for typing it all together:

https://github.com/lukedirtwalker/cutespotify/blob/16812522a6c087c645008705d02ffd02e6e3c6e6/qml/SearchPage.qml#L35

hetas commented 6 years ago

Search doesn't work for me if I the search term has spaces in it. Trim only removes whitespace from the ends of the string so I don't think that makes a difference.

I'd guess that the search term isn't url-encoded and it needs to be. Replacing spaces with '+' might do the trick.