lukeed / clsx

A tiny (239B) utility for constructing `className` strings conditionally.
MIT License
8.21k stars 142 forks source link

fix: improve type test #99

Open brunoti opened 4 months ago

brunoti commented 4 months ago

I was making some BEM CSS transformers for Vite and stumbled on a bug:

The module.css will be transformed to something resembling this:

const ClassIdentifierMap = {}
ClassIdentifierMap['block'] = new String('block')
ClassIdentifierMap['block']['element'] = new String('block__element')
ClassIdentifierMap['block']['element']['$hasError'] = new String('block__element--has-error')

export default ClassIdentifierMap

Using it as:

import classes from './Whatever.module.css'

clsx(classes.block.element, hasError && classes.block.element.$hasError)

It will always fail because it will check and fail to see that all those are strings, treat it as an object, and try to check the keys.

This PR fixes it on both clsx and clsx/lite.

brunoti commented 4 months ago

Converted to draft to add tests

brunoti commented 4 months ago

Tests added!