search

lukeed / ley

(WIP) Driver-agnostic database migrations
MIT License
260 stars 14 forks source link

Remove indentation and comment #17

Closed karlhorky closed 3 years ago

karlhorky commented 3 years ago

Potential alternative approach to #16

codecov-io commented 3 years ago

Codecov Report

Merging #17 (1a306f5) into master (39f6052) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   47.00%   47.00%           
=======================================
  Files           2        2           
  Lines         117      117           
=======================================
  Hits           55       55           
  Misses         62       62
Impacted Files Coverage Δ
index.js 11.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 39f6052...1a306f5. Read the comment docs.

karlhorky commented 3 years ago

Or @lukeed, now that I've been writing ESM migrations, it got me thinking - maybe this PR would be more valuable if it achieved both of the following:

  1. avoid adding either space or tab indentation to template (like the PR currently is)
  2. allow for an ESM template
karlhorky commented 3 years ago

I was also thinking about adding a TypeScript or JSDoc template, but I guess that means at least 5 different versions, because of the annotations for all of the different libraries. (based on the auto-detection built into ley of which driver to use)

I guess it's not too much one-time work, but there would be a possible maintenance cost with those type imports.

karlhorky commented 3 years ago

Reopened as #21