Open tiffany352 opened 4 years ago
I hit this as well. I think that Polka should go back to the 0.x behavior for URL parsing. I don't want Polka to touch my URL at all but just pass along what was received. Netlify tried to decode just as Polka 1.x was trying and they decided it was a bad idea and had to revert the change just as I think we should here as well: https://answers.netlify.com/t/bug-fix-url-encoding-preserved-in-function-event/27080
I have an app with a query endpoint like
/query/:input
and sometimes the input can be something like1/7
.I would have a url like
/query/1%20%2F%207
(percent encoded1 / 7
) and end up getting a 404 page. I added a console.log call and it turned out this was being decoded into/query/1 / 7
inrequest.url
. Express doesn't have this issue, for comparison.I was using the
next
version from NPM because that was the default in the Sapper template.Repro
Expected behavior / Express behavior
200 OK with body:
Actual behavior (5.2.0)
200 OK with body:
(input is urlencoded when it should be decoded)
Actual behavior (next)
Server prints
url /query/1 / 7
.Curl sees 404 Not Found.