search

lukeed / pwa

(WIP) Universal PWA Builder
https://pwa.cafe
3.13k stars 100 forks source link

Show TSLint in "Linter/Formatter" when TypeScript selected #44

Open tatchi opened 5 years ago

tatchi commented 5 years ago

My attempt to implement second point of #36.

As soon as "Linter/Formatter" feature is selected, all options are displayed (regardless of TypeScriptselection). If TypeScriptis selected but not the "Linter/Formatter", only TSLintoption is proposed.

Hope that the logic is correct :grimacing:

Don't hesitate if you see any improvement :blush:

lukeed commented 5 years ago

Thanks @tatchi~!

I think that TSLint should only appear when Linter or Formatter feature is selected, so the logic is doing more than it should IMO.

I'll make that change for you once I get TS in completely 👍 Holding off on merging this until then.

🙇

tatchi commented 5 years ago

Thanks @lukeed :)

I still changed the logic: now it displays the options only when Linter or Formatter feature is selected. If TypeScript is selected then it shows TSLint, otherwise ESLint

Feel free to change if it's still not aligned with your expectation :)