Angular - Githubissues

lukeed / pwa

(WIP) Universal PWA Builder

https://pwa.cafe

3.13k stars 101 forks source link

Angular #8

Open lukeed opened 6 years ago

lukeed commented 6 years ago

Add new @pwa/preset-angular package.

I'm super out of touch with Angular, so this will need some research.

MarkRabey commented 6 years ago

I've worked with Angular a fair amount. It's best used with @angular/cli, and uses TypeScript. I'd love to help implement. I've forked the repo for that reason. I'll probably do it any, but if for some reason you're against it, let me know.

lukeed commented 6 years ago

Hey, awesome! That would be great! Although, I'd expect that to likely be an involved PR, just a heads up 😜

Does Angular now require TS, or is it just part of standard convention?

Either way, I have a TS plugin mostly complete. If Angular does require TS, we'd build off/alongside that plugin as opposed to installing all of TS & co in the Angular preset a second time.

housseindjirdeh commented 6 years ago

This is an awesome project, and I'm definitely excited to see it grow to include an Angular preset :)

AFAIK, you can't bootstrap a new Angular CLI project without TS.

Some additional notes (in case it helps):

The CLI has support for style preprocessers (less, scss and stylus are all supported if I'm not mistaken). Can start a new project with one like this:
- ng new new-app --style=scss
@angular/router is how routing is built into the framework. It also supports lazy loading different feature modules out of the box
@angular/pwa can be used to add a service worker to an Angular CLI app

lukeed commented 6 years ago

Awesome, thank you @housseindjirdeh ~!

All sounds good, thanks. So then that definitely places #5 as a pre-req 👍

Those other behaviors should be working out of the box. If Angular works like 99.9% of everything else, it's just a matter of emitting the particular content type(s) into the Webpack sphere & allowing the delegated-n-designated loaders handle the rest.

There's some good visibility here so far, so I'll definitely come back with questions since I haven't meddled w/ Angular since early 2.x 👻

That is, if @MarkRabey doesn't beat me to it 🙌

MarkRabey commented 6 years ago

Sorry, I've hit a wall, so to speak, in terms of time. While I'd love to help out with this, it's probably best someone else take care of it. I've barely had time to think about it the past few days.

lukeed commented 6 years ago

Not to worry @MarkRabey! However much or little (or none) you're able to contribute is super appreciated. 👍