lukeed / resolve.exports

A tiny (952b), correct, general-purpose, and configurable `"exports"` and `"imports"` resolver without file-system reliance
MIT License
368 stars 15 forks source link

tests: Invert comments on pattern trailer handling, extend test values #23

Closed huntie closed 1 year ago

huntie commented 1 year ago

Hey, I've been looking through the tests for this library and spotted something which I'd interpreted differently in the spec. Specifically, the behaviour of pattern trailers for subpath exports, described in more detail here: https://github.com/nodejs/node/pull/39635.

Changes:

codecov-commenter commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (e0a914b) compared to base (587b0ba). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #23 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 51 52 +1 ========================================= + Hits 51 52 +1 ``` | [Impacted Files](https://codecov.io/gh/lukeed/resolve.exports/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Luke+Edwards) | Coverage Δ | | |---|---|---| | [src/index.js](https://codecov.io/gh/lukeed/resolve.exports/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Luke+Edwards#diff-c3JjL2luZGV4Lmpz) | `100.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Luke+Edwards). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Luke+Edwards)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.