search

lukeed / svelte-demo

Multi-page demo built Svelte 3.x and Rollup with code-splitting
MIT License
114 stars 19 forks source link

Infinite fetch... #2

Closed frederikhors closed 5 years ago

frederikhors commented 5 years ago

Something is wrong:

image

lukeed commented 5 years ago

Need to see source. Is it the code from repo unchanged?

frederikhors commented 5 years ago

Yeah. Just git clone.

lukeed commented 5 years ago

Hmm.. sorry now looking into this.

Do you know if everything is up to date? I know this used to be the case, hence this commit (https://github.com/lukeed/svelte-demo/commit/43ec249674586c742fc3cefb469552048bb80faa), but I was able to revert it after a Svelte update.

I just installed this repo from scratch with fresh dependencies, and at most there are 2 fetches to the same JSON endpoint.

lukeed commented 5 years ago

Ah, no, you're right! I had done an exact-match installation. Somewhere been 3.0.0 and 3.4.4 this regression happened.

frederikhors commented 5 years ago

Can you explain it, please?

Is a Svelte related issue?

lukeed commented 5 years ago

Still trying to figure it out to be honest. I have issued opened, but not sure yet if I had based the work on a bug, or if it not working now is the bug.

frederikhors commented 5 years ago

Can you please re-open this so I can catch a news on it in the future? Thanks.

lukeed commented 5 years ago

The issue is fixed / patched for this repo. You should subscribe upstream since that's where the discussion and fix(es) will come from.

If something else needs to happen in/for this repo, I'll comment here which will notify you. But it's currently not an issue as presented