Closed lukeed closed 7 years ago
Strong plus from my side for Flow
, basically it will be a good combo with
Rewrite with supported ES2015 features https://github.com/flyjs/fly/issues/203
I decided not to use Flow in order to stay true to the "lightweight" mission of Fly.
Although it wouldn't affect user downloads, it adds a couple of extra steps to the process, which then opens the door for more... then more... in the future. Then Fly would end up in the same mess it was when I came aboard.
IMO, for now, keep everything as lean as possible. If something arises that demands a compile step, then we'll add Flow in at that time.
@lukeed Not the same, but while we're talking about types, what about adding a type definition file for the API.
@jbucaran Howdy! Sure, not opposed to that.
@lukeed Would you like to add type definitions for Flow
and Typescript
, or can I ?
@hzlmn @jbucaran Let's wait until #229 is resolved. That still poses a threat to rewriting the current API... perhaps drastically (but I hope not).
I'm hoping to spend this weekend and/or next weekend on finding a good solution.
Ok, got it.
@lukeed Seems like API pretty stable, should we add definition files 🤔?
Sure, go for it! I don't use TS so forgot about this.
Either Flow or Typescript.
(cool flow plugin. im sure there are others)
Pro
Con