lukeed / taskr

A fast, concurrency-focused task automation tool.
MIT License
2.53k stars 74 forks source link

Use Type Checker? #214

Closed lukeed closed 7 years ago

lukeed commented 7 years ago

Either Flow or Typescript.

(cool flow plugin. im sure there are others)

Pro

hzlmn commented 7 years ago

Strong plus from my side for Flow, basically it will be a good combo with

Rewrite with supported ES2015 features https://github.com/flyjs/fly/issues/203

lukeed commented 7 years ago

I decided not to use Flow in order to stay true to the "lightweight" mission of Fly.

Although it wouldn't affect user downloads, it adds a couple of extra steps to the process, which then opens the door for more... then more... in the future. Then Fly would end up in the same mess it was when I came aboard.

IMO, for now, keep everything as lean as possible. If something arises that demands a compile step, then we'll add Flow in at that time.

jorgebucaran commented 7 years ago

@lukeed Not the same, but while we're talking about types, what about adding a type definition file for the API.

lukeed commented 7 years ago

@jbucaran Howdy! Sure, not opposed to that.

hzlmn commented 7 years ago

@lukeed Would you like to add type definitions for Flow and Typescript, or can I ?

lukeed commented 7 years ago

@hzlmn @jbucaran Let's wait until #229 is resolved. That still poses a threat to rewriting the current API... perhaps drastically (but I hope not).

I'm hoping to spend this weekend and/or next weekend on finding a good solution.

hzlmn commented 7 years ago

Ok, got it.

hzlmn commented 7 years ago

@lukeed Seems like API pretty stable, should we add definition files 🤔?

lukeed commented 7 years ago

Sure, go for it! I don't use TS so forgot about this.