extract `fly.watch` to plugin

lukeed / taskr

A fast, concurrency-focused task automation tool.

MIT License

2.53k stars 74 forks source link

extract `fly.watch` to plugin #245

Closed lukeed closed 7 years ago

lukeed commented 7 years ago

As noted in the commit's comment:

Total time taken for tests execution dropped by 60% !!!

cc/ @jbucaran @hzlmn

jorgebucaran commented 7 years ago

@lukeed What do you mean? watch is still something I imagine end users will want to do anyway. No?

EDIT: Nevermind ;)

lukeed commented 7 years ago

Yes, but not all. Now it's installed via fly-watch. I thought we both agreed on this yesterday.

jorgebucaran commented 7 years ago

About separating fly.watch into its own plugin, I agree.

What I realize now, is that 60% test exec drop refers to fly tests, which for reason I misinterpret as tasks running 60% faster.

lukeed commented 7 years ago

Ah, yeah. I made that optimization a long time ago, wherein chokidar became lazy-loaded instead of eagerly loaded so that only those who actually ran fly.watch loaded up Chokidar.

We got same perf boost there too.

I'll link to that commit when I get back to computer.

lukeed commented 7 years ago

@jbucaran for reference: 12ec1a3edcbf4402b080f49cd3974f04d73cf4ce and #236