Reduce dependencies - Githubissues

lukeed / taskr

A fast, concurrency-focused task automation tool.

MIT License

2.53k stars 74 forks source link

Reduce dependencies #247

Closed jorgebucaran closed 7 years ago

jorgebucaran commented 7 years ago

Suggestions

bluebird is fast, that's the thing right?
Instead of globby, node-glob should be enough.
We could probably drop prettyjson and the prettylog with its crappy regex which has not changed much since I wrote it
Arrify is ridiculous.
Let's get rid of update-notifier and do nothing instead.
I'd like to use clor, instead of chalk. No biggie here, but a personal preference.
flatten is fine for now, but would like to revisit this, either pick another library, or find a way to not need to flatten arrays.
We can drop dev deps like tap-spec. As long as the test output is tap, it's fine.
I don't find linters much useful nowadays. I think fly could do without xo, but this is not a priority.

List

[x] globby
[x] flatten
[x] prettyjson
[x] arrify
[x] update-notifier
[x] chalk->clor

lukeed commented 7 years ago

Keeping tap-spec, xo and flatten.

Would prefer to keep update-notifier.

We can probably drop bluebird when node 8 becomes stable. TBD

Let's worry about clor vs chalk after 2.0. As I've mentioned, I have no preference so long as clor is cross compatible. (Not using clor/c)

The rest I can do without.

jorgebucaran commented 7 years ago

Why not using clor/c? It's optional.

What's the big deal about update-notifier anyway?

lukeed commented 7 years ago

Yea, I know it's optional. Just prefer the current pattern.

We have a lot of users who use Fly globally. Much harder for them to keep track of updates without it.

jorgebucaran commented 7 years ago

It was probably my mistake if I tried to emulate gulp. It was probably easier to test run things with a global fly in the beginning too.

Anyway, using fly globally should be discouraged IMO.

lukeed commented 7 years ago

Gotcha. I agree, I never think Fly is a good idea for global use. But shouldn't we at least notify 1.x users that 2.0 is out?

jorgebucaran commented 7 years ago

Ok, let's revisit update-notifier in the future and keep this issue to track the avada kedavra of the other deps. I'll create another issue in due time wrt to the switch to 🌈 clor.

EDIT: I've assigned myself, so you don't need to worry about this for now.

lukeed commented 7 years ago

Haha okay. I'm taking care of arrify and globby now. I'm also editing this task to become a checklist.

lukeed commented 7 years ago

I went ahead & remove update-notifier. I went back & counted our global-related issues and it wasn't as many as I thought.