Clormetics: Clor + Cosmetics

lukeed / taskr

A fast, concurrency-focused task automation tool.

MIT License

2.53k stars 74 forks source link

Clormetics: Clor + Cosmetics #248

Closed jorgebucaran closed 7 years ago

jorgebucaran commented 7 years ago

Switch back to clor.

Cosmetic changes: bring back double quotes and remove ;.

lukeed commented 7 years ago

Can you please add the .editorconfig back in? You may not use it, but it's actually quite popular & autofixes a bunch of spacing.

lukeed commented 7 years ago

Thanks! I'm just waiting for AppVeyor to finish testing.

jorgebucaran commented 7 years ago

I can understand that, as I was into it before. I don't like it so much now, but you have a point. I put it back!

lukeed commented 7 years ago

You dropped my XO 😿

Any chance I can compromise with you? I'll trade you no-semis for using single quotes instead

jorgebucaran commented 7 years ago

What do you say we go without xo for a while. If you feel uncomfortable without it after that, then by all means put it back! 👍

lukeed commented 7 years ago

It's actually quite painful (double quotes) haha. It's two keystrokes for one one character, every time.

I'm okay dropping XO. But we should get a customized ESLint replacement in the future. It'd be silly not to.

jorgebucaran commented 7 years ago

I don't like linters, but I won't oppose you if you really feel the show can't go on without one.

lukeed commented 7 years ago

It's a good idea to, especially once others start contributing again. It gets really messy quite quickly, which is something you admitted about Fly 0.8

hzlmn commented 7 years ago

This style is quite similar to standard except double quotes.

lukeed commented 7 years ago

@hzlmn 👋 Correct! Can we all agree on single quotes?

jorgebucaran commented 7 years ago

I always use double quotes and it was double quotes once before.

lukeed commented 7 years ago

So, no compromises? I see.

hzlmn commented 7 years ago

As for me, styling problems are not problems at all. I think as Jorge is original author we can agree with his decision. Does it work for you? @lukeed

jorgebucaran commented 7 years ago

Actually, here is the back story, it is way harder to type single quotes for me, since my keyboard is in Japanese and the ' is the weirdest position.

EDIT: It's above the number 7, so I'd need to type shift+7, lol. " is just shift+2

lukeed commented 7 years ago

That sucks! lol

Luckily 2.0 is almost done. Not many " left to be typed.

jorgebucaran commented 7 years ago

So, no compromises? I see.

IIRC " is on the same spot in English keyboards? So, technically this makes us even!

Thanks 🙇 for merging.

lukeed commented 7 years ago

Yea, it is. My point was that ' is 1 keystroke (') and " is 2 (Shift + '). Just a redundant stroke every time 😜, adds up tho.

jorgebucaran commented 7 years ago

I said I dislike linters, but I'd be thrilled to give https://github.com/jlongster/prettier a try. I am used to syntax formatters like gofmt, and I think they are fabulous.

lukeed commented 7 years ago

Okay, would be curious to try it out. But we would wait on this one in particular. I've already seen at least 2 format changes since I heard about it.