search

lukeed / taskr

A fast, concurrency-focused task automation tool.
MIT License
2.53k stars 74 forks source link

Continue Node4 (LTS) Support #258

Closed lukeed closed 7 years ago

lukeed commented 7 years ago

Dropped 4.x support a bit too early. It turns out that many developers & OSS projects still actively support & use v4, so we should too in order to be approachable. This was my only hesitation before switching.

Nothing changes in terms of performance or features. One spread and one rest operator were changed within Fly's actual codebase. Every other change is a destructured assignment thru require().

Opens #242 once again. Will revisit in April.

Akkuma commented 7 years ago

You could always use buble and have a prepublish script to convert the files to node v4 compatible and then when v4 is officially dropped, stop using the prepublish script. Unlike babel, buble will probably provide 99% of what you want with 0 configuration.

jorgebucaran commented 7 years ago

Probably, yes, but I'm basically okay with this. 4 support ends when @lukeed ?

lukeed commented 7 years ago

Yes, but would have to be careful to leave the external dependencies as external dependencies, otherwise we package code that will be downloaded and linked elsewhere, without sharing.

LTS ends April, so I don't mind this for a little while. No substantial changes.

I also want to avoid a compile step, if possible, and really would want more reason to need a compile besides an ES5 transformation.