search

lukeed / taskr

A fast, concurrency-focused task automation tool.
MIT License
2.53k stars 74 forks source link

Fixed spelling mistakes and grammar #265

Closed abhisheksoni27 closed 7 years ago

jorgebucaran commented 7 years ago

LGTM

Swizz commented 7 years ago

Why all this tabs changes in the source code ?

abhisheksoni27 commented 7 years ago

I saw them and rechecked the actual presentation of the README.md in my forked repo and it looked exactly the same. I don't know why the tabs changed, though. I use VS code. Could that have done this? :thinking:

Should I try editing on Sublime/Atom?

jorgebucaran commented 7 years ago

I think we using tabs it's my fault. 😅

abhisheksoni27 commented 7 years ago

So which convention would you like the code to follow?

abhisheksoni27 commented 7 years ago

Also, @jbucaran, I filed an issue over at Travis-CI because the node-7.7.3 test failed. (It was due to an internal network trouble in downloading the tarball. )

They want you to restart the build again to see if the issue has resolved.

Could you? Here's a link to the issue I filed: Why is Travis CI taking too long to download Node.js

lukeed commented 7 years ago

Thanks @abhisheksoni27!

Also, there's no need for a Travis issue. It halted because it was processing a lot of PRs/commits at once. You'll see that it's now passing. :)

abhisheksoni27 commented 7 years ago

@lukeed – Thanks for reviewing!

Also, you are right. They are now passing. But check this: Travis Incident Page

They think it's an upstream issue. You should tell them if you are sure it was just Travis getting overwhelmed.

lukeed commented 7 years ago

Thanks @abhisheksoni27. I think it's something to do with my own configuration inside Travis. I'll take a look!

Thank you for proofreading! 🙏 One can only stare at the same wall of text before insanity strikes.

abhisheksoni27 commented 7 years ago

You're welcome. :tada:

Thanks for the project, @lukeed. One can only type the same commands before automation strikes.