Closed abhisheksoni27 closed 7 years ago
Why all this tabs changes in the source code ?
I saw them and rechecked the actual presentation of the README.md in my forked repo and it looked exactly the same. I don't know why the tabs changed, though. I use VS code. Could that have done this? :thinking:
Should I try editing on Sublime/Atom?
I think we using tabs it's my fault. 😅
So which convention would you like the code to follow?
Also, @jbucaran, I filed an issue over at Travis-CI
because the node-7.7.3
test failed. (It was due to an internal network trouble in downloading the tarball. )
They want you to restart the build again to see if the issue has resolved.
Could you? Here's a link to the issue I filed: Why is Travis CI taking too long to download Node.js
Thanks @abhisheksoni27!
Also, there's no need for a Travis issue. It halted because it was processing a lot of PRs/commits at once. You'll see that it's now passing. :)
@lukeed – Thanks for reviewing!
Also, you are right. They are now passing. But check this: Travis Incident Page
They think it's an upstream issue. You should tell them if you are sure it was just Travis getting overwhelmed.
Thanks @abhisheksoni27. I think it's something to do with my own configuration inside Travis. I'll take a look!
Thank you for proofreading! 🙏 One can only stare at the same wall of text before insanity strikes.
You're welcome. :tada:
Thanks for the project, @lukeed. One can only type the same commands before automation strikes.
LGTM