search

lukeed / taskr

A fast, concurrency-focused task automation tool.
MIT License
2.53k stars 75 forks source link

Update to Babel 7.x #305

Closed benedyktdryl closed 5 years ago

benedyktdryl commented 6 years ago

Hi,

This is my very firs PR which includes Babel 7.x related updates. Please let me know if you will be interested in such contribution so I can make further updates in that matter.

lukeed commented 6 years ago

Hey, very cool. Thanks!

Do you think Babel 7 is stable enough to use in production? I see that it's still beta & I know personally that they want more people to test 7 before it's an official release.

I think this is the case, correct me if I'm wrong~! But if so, we should hold off on Babel 7 until it's out of beta. We'll accept this PR when that time comes 😃

benedyktdryl commented 6 years ago

Cool - I know it's beta. I made this branch for other guys so they can try to link this version if needed. I will keep eyes on this and go back when it will be more production ready.

lukeed commented 6 years ago

Great, thanks!

hzlmn commented 6 years ago

@lukeed maybe we can publish it under beta tag? Would like to give it a try and do not want manually fetch from git repo 🐵

benedyktdryl commented 6 years ago

I also want to ask for release it under beta tag as it will be easier to test it and also - it would help me a lot to maintain this PR:

https://github.com/zeit/next.js/pull/3428

lukeed commented 6 years ago

I'm going to be releasing this as a next tag, along with some changes to the Taskr itself under a next tag.

I'll come back here shortly when that's prepped!

timneutkens commented 6 years ago

@lukeed could you release this as next? We're planning to move Next.js to babel 7 soon.

lukeed commented 6 years ago

Sure, tbh I forgot about this. I've been messing with Taskr core locally at one point and was hoping it publish it all under the next or beta tag

timneutkens commented 6 years ago

Thanks! Only this would be fine, don't want to fork and release our own version to test 😄

timneutkens commented 6 years ago

Just tried it out locally and the PR seems to work well 👍

timneutkens commented 6 years ago

@lukeed if you could release it that'd be awesome, it's the only thing holding back the tests in my PR 😄

lukeed commented 6 years ago

Do any of the beta deps need to be updated?

timneutkens commented 6 years ago

yeah looks like they need to be upgraded to the latest beta, which I believe is .42

lukeed commented 6 years ago

This is now available as @taskr/babel@next 🎉

I will merge when I'm ready to make the remaining Taskr changes. Thank you all & sorry for the untimely delay(s)~!

timneutkens commented 6 years ago

Nice! Thanks Luke 🙏

lukeed commented 5 years ago

Moving this into a separate babel branch since it's still under a next tag release. The request from #315 should also be applied to this (new) branch, moving this @taskr/babel@next off the beta version.

Thanks!