search

lukeed / trouter

:fish: A fast, small-but-mighty, familiar fish...errr, router*
MIT License
634 stars 23 forks source link

TypeScript definitions #7

Closed luvies closed 5 years ago

luvies commented 5 years ago

I noticed that there were TS definitions in this package, but they were removed in favour of using DefinitelyTyped, however I cannot find the definitions in that package. Are they under a different name, or have they not been added, and if not, could you add in the definition file again (I think it's normally preferable for the package to have the definitions rather than rely on DefinitelyTyped anyway)? I can provide a definition file for this package if you wanted to add them back in to here, since I needed them anyway (I also made changes to it that made the definitions better to use).

lukeed commented 5 years ago

They are now available via @types/trouter thanks to @stahlstift (and @fwilkerson in the past) 🙌

source