search

lukeed / tsm

TypeScript Module Loader
MIT License
1.18k stars 19 forks source link

fix: add support for Node.js v18.6.0 #37

Closed antongolub closed 2 years ago

antongolub commented 2 years ago

closes #36

https://github.com/microsoft/playwright/pull/15694/files

antongolub commented 2 years ago

btw, esbuld >= 0.14.32 breaks tsc buld.

lukeed commented 2 years ago

Why they didn't add this flag with a true default value is beyond me. So annoying... intra-version breaking change. Node team continues to ace the ESM rollout 🙄

antongolub commented 2 years ago

ESM is our python3-like frustrative challenge)

@lukeed, Do you know what is returnd by fallback? Should we use return Object.assign(await fallback(...), {shortCircuit: true}) or return fallback(...) would be enough?