sass support - Githubissues

lukehaas / css-loaders

A collection of loading spinners animated with CSS

MIT License

7.05k stars 1.04k forks source link

sass support #22

Open andreasonny83 opened 8 years ago

andreasonny83 commented 8 years ago

demo project inside the repo
distribution folder with the minimized version of the library for start using css-loaders in other projects
documentation updated
removed unused code
package.json fixed
other minor improvements

lukehaas commented 8 years ago

@andreasonny83 thanks for making this request. It looks like with this update compiled CSS would be part of the repo, as you haven't added the new /dist directory to gitignore. Is that something you intended?

andreasonny83 commented 8 years ago

Yes, that's right. The dist folder will be visible in the repository containing the latest stable build of the library. In this way, people can simply download the zipped version or cloning the repository and start using the cssloader in their projects without the need of installing all the node packages and compile a new version every time.

andreasonny83 commented 8 years ago

It is quite common to have a dist folder from where people can start using the library without compiling the source code. Have a look at the Twitter Bootstrap repository for example: https://github.com/twbs/bootstrap

andreasonny83 commented 8 years ago

Hi @lukehaas, I merged your latest step2 branch inside this pull request to resolve some merge conflicts. The pull request is clean again and ready to be merged. Let me know if you're happy with this.

lukehaas commented 8 years ago

Thanks @andreasonny83, you're right, it's a good idea to have the compiled css available. However, I'm not keen to have the demo site code in the repo. Also, the demo site is created in jade and compiled to html, but your updates remove the jade compilation from grunt.