search

lukeholder / craft-dbug

Dbug adds pretty template debugging to Craft CMS
24 stars 2 forks source link

Casing #4

Closed narration-sd closed 10 years ago

narration-sd commented 10 years ago

Luke, I've corrected that filename, as it is correct in the release zip, but still not in the repository when you clone it. Thus this pull request, where you can see nothing changed but the filename. Without the change, on *n[i|u]x, Craft crashes.

I bet the reason this wasn't quite right yet in spite of your efforts is shown by what I had to do to fix it. Git, at least through TortoiseGit, does not recognize a case-changed filename, not even if you make a content change (I tried adding a harmless space).

Anyway, I found the situation out by finding how easy it was to understand and use Composer; made my own local build. A sensible tool, surely.

Take care, Clive

lukeholder commented 10 years ago

Thanks narration, I have made this change in the repo but also fixed the creation of this class to also be uppercase - so although I will not pull this request the changes have been made. Hopefully the newly uploaded v2 zip will work for you now.

narration-sd commented 10 years ago

Sounds good – either way will work.

I’ll sync the repository later and rebuild with compass, just to be caught up.

Too late here now – shuteye in store….